Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior when filtering 'Query Results (Preview)' grid on columns containing NULL values #18715

Closed
jonp0 opened this issue Feb 19, 2025 · 3 comments

Comments

@jonp0
Copy link

jonp0 commented Feb 19, 2025

  • MSSQL Extension Version: 1.28.0
  • Version: 1.97.2 (user setup)
  • Commit: e54c774e0add60467559eb0d1e229c6452cf8447
  • Date: 2025-02-12T23:20:35.343Z
  • Electron: 32.2.7
  • ElectronBuildId: 10982180
  • Chromium: 128.0.6613.186
  • Node.js: 20.18.1
  • V8: 12.8.374.38-electron.0
  • OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

  1. Run a query whose output contains NULL values, e.g.:
select 0 [col_a], 0 [col_b], 0 [col_c], 'a' [col_d]
UNION
select 0 , 0 , 99, 'a' 
UNION
select 0 , 1 , null, 'b' 
UNION
select 1 , 0 , 98, 'b' 
UNION
select 1 , 1 , 97, 'a' 
UNION
select 1 , 0 , null, 'a' 
UNION
select 1 , 1 , 96, 'b'
  1. Filter the output grid on [col_c] = 99 >>> Output is filtered as expected
  2. Filter the output grid on [col_c] = 96 >>> Output disappears as if filter returns nothing
  3. Filter the output grid on [col_c] = 0 >>> Output is filtered as expected
  4. Filter the output grid on [col_c] = NULL >>> Output disappears as if filter returns nothing
  5. Filters on all other columns work as expected
@cssuh
Copy link
Member

cssuh commented Mar 3, 2025

Hi @jonp0 we made some updates to the query filtering experience in version 1.29. Can you please give it a try to see if this fixes your issue?

@jonp0
Copy link
Author

jonp0 commented Mar 3, 2025

Hi @cssuh ,
Upon initial testing with the same query above (and a few others), it looks like this specific issue is fixed in 1.29.0. Thanks!

@cssuh
Copy link
Member

cssuh commented Mar 3, 2025

@jonp0 , thanks for the quick reply. I'll close this issue since it's fixed.

@cssuh cssuh closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants