Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring form controller logic to base class for reuse #18842

Merged
merged 4 commits into from
Mar 1, 2025

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Feb 25, 2025

Moving some of the sharable logic for forms to a base class. Other form UIs (like container deployment) should be able to reuse the formAction reducer, validation, and error reporting now.

Copy link

github-actions bot commented Feb 25, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.66% 50.77% .11 %
VSIX Size 12982 KB 12983 KB 1 K B   ( 0 % )
Webview Bundle Size 3188 KB 3188 KB 0 K B   ( 0 % )

@Benjin Benjin merged commit 8c93b31 into main Mar 1, 2025
6 checks passed
@Benjin Benjin deleted the dev/benjin/formController branch March 1, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants