Should default themes specify link hover color?

[usernamehw]

On the web (and not only) links usually react to hover (underline or color change). Right now in vscode in some places there is underline, like in markdown preview, in other places there is no style change, like in Settings UI or an editor hover.

There is already a color for that textLink.activeForeground. I think it would be better if default themes specified it.

[aeschli]

Can you add screenshots of the places that you miss the undeline?
textLink.activeForeground is intended for text in a rich editor like the settings or welcome editor.
Editor hover would need a new color.

[usernamehw]

Example of editor hover (now):

const markdown = new MarkdownString(undefined, true);
markdown.appendMarkdown(`[How](https://www.google.com) [many](https://www.google.com) [links](https://www.google.com) [here?](https://www.google.com)`);
return new Hover(markdown);

Example of when the color is defined:

"workbench.colorCustomizations": {
		"textLink.activeForeground": "#fc9867",
}

[aeschli]

Ok if we make this issue about underlines in the hover only? That makes it easier to manage the issue.

[usernamehw]

Ok if we make this issue about underlines in the hover only?

If you think that would be better.

[aeschli]

Ignore my comment about a new color.

I agree with the request. We should make use of textLink.activeForeground.

The color is used at many places where links are shown. But nobody is aware of it as by default it is the same as `textLink.foreground'.

@misolori What do you think?

Assigning to you as you'd have come up with actual color values for light and dark.

To verify: Open the Welcome page and move the mouse over the links.

[miguelsolorio]

This one is tricky because we already have a bright link color that we use, primarily because we use links in a lot of places and need to make sure it passes the color contrast ratio. The list hover (in notifications and settings) is the one where we need to pass the minimum since it has a brighter hover color:

An alternative would be to use text underlines for hovers but I thought we removed those a while back?

[usernamehw]

This issue went nowhere.