Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments panel: Line numbers too far to the right #239221

Closed
chrmarti opened this issue Jan 30, 2025 · 6 comments · Fixed by #239241, #239815 or #242175
Closed

Comments panel: Line numbers too far to the right #239221

chrmarti opened this issue Jan 30, 2025 · 6 comments · Fixed by #239241, #239815 or #242175
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2025

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Jan 30, 2025 •
edited
Loading

The line numbers are moved too far to the right, they are partially hidden by the border:
Image

Image

From #226415
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Jan 30, 2025
@alexr00 alexr00 added this to the January 2025 milestone Jan 30, 2025
alexr00 added a commit that referenced this issue Jan 30, 2025
@alexr00
Comments panel: Line numbers too far to the right
99c12dc 
Fixes #239221
@alexr00 alexr00 mentioned this issue Jan 30, 2025
Merged
alexr00 added a commit that referenced this issue Jan 30, 2025
@alexr00
Comments panel: Line numbers too far to the right (#239241)
77afd22 
Fixes #239221
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 30, 2025
@eleanorjboyd
Copy link
Member

still seeing, wondering it is release yet but seems like yes from the bots actions?

Image

@connor4312 connor4312 added verified Verification succeeded and removed verified Verification succeeded labels Jan 31, 2025
@rzhao271
Copy link
Contributor

I see the same thing. Adding verification-found.

@rzhao271 rzhao271 reopened this Jan 31, 2025
@rzhao271 rzhao271 added the verification-found Issue verification failed label Jan 31, 2025
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Jan 31, 2025
@alexr00
Copy link
Member

alexr00 commented Feb 3, 2025

@eleanorjboyd your picture actually looks correct. The line number is shorted with a ... instead of simply being cut off.

@alexr00 alexr00 closed this as completed Feb 3, 2025
@alexr00 alexr00 added verified Verification succeeded and removed verification-found Issue verification failed labels Feb 3, 2025
@chrmarti
Copy link
Collaborator Author

chrmarti commented Feb 3, 2025

@alexr00 I think having a single ellipsis on one line would look cleaner. The line number could be shown in full while the comment text keeps the ellipsis.

@alexr00 alexr00 reopened this Feb 3, 2025
@alexr00 alexr00 removed the verified Verification succeeded label Feb 3, 2025
@alexr00 alexr00 modified the milestones: January 2025, February 2025 Feb 3, 2025
alexr00 added a commit that referenced this issue Feb 6, 2025
@alexr00
Comments panel: Line numbers too far to the right
01667eb 
Fixes #239221
@alexr00 alexr00 mentioned this issue Feb 6, 2025
Merged
@alexr00 alexr00 closed this as completed in 287a31a Feb 6, 2025
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 6, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 7, 2025
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 26, 2025
@rzhao271
Copy link
Contributor

The line number still seems cut off to me.

Only the starting bracket appears. The line number is off the screen to the right.

@rzhao271 rzhao271 reopened this Feb 26, 2025
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Feb 26, 2025
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Feb 26, 2025
alexr00 added a commit that referenced this issue Feb 27, 2025
@alexr00
Comments panel: Line numbers too far to the right
201b5c1 
Fixes #239221
@alexr00 alexr00 mentioned this issue Feb 27, 2025
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 27, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 28, 2025
@alexr00 alexr00 removed the verification-found Issue verification failed label Feb 28, 2025
@roblourens
Copy link
Member

Line number is fine but seems like there could be room for the timestamp

Image

@roblourens roblourens added the verified Verification succeeded label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2025
6 participants
@roblourens @connor4312 @rzhao271 @chrmarti @eleanorjboyd @alexr00