Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add diff toggling keybinding to edits a11y help dialog #239325

Closed
meganrogge opened this issue Jan 31, 2025 · 2 comments · Fixed by #239377 or #242220
Closed

add diff toggling keybinding to edits a11y help dialog #239325

meganrogge opened this issue Jan 31, 2025 · 2 comments · Fixed by #239377 or #242220
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2025

Comments

@meganrogge
Copy link
Contributor

we now have a keybining to toggle the diff view, but need to make it discoverable cc @jooyoungseo

related #238717
@meganrogge meganrogge self-assigned this Jan 31, 2025
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 31, 2025
meganrogge added a commit that referenced this issue Jan 31, 2025
@meganrogge
fix #239325
ebbe85a
@meganrogge meganrogge mentioned this issue Jan 31, 2025
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders labels Jan 31, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 6, 2025
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 27, 2025
@rzhao271
Copy link
Contributor

@meganrogge I don't see a diffhunk command, and the dialog says unassigned keybinding. Did you mean to reference chatEditor.action.toggleDiff?

@rzhao271 rzhao271 reopened this Feb 27, 2025
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Feb 27, 2025
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Feb 27, 2025
@meganrogge
Copy link
Contributor Author

@rzhao271 , it looks like that command name changed, so yes, I need to update it.

meganrogge added a commit that referenced this issue Feb 27, 2025
@meganrogge
fixes #239325
65f68f3
@meganrogge meganrogge mentioned this issue Feb 27, 2025
Merged
@meganrogge meganrogge removed the verification-found Issue verification failed label Feb 27, 2025
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 27, 2025
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Feb 28, 2025
@vs-code-engineering vs-code-engineering bot added the insiders-released Patch has been released in VS Code Insiders label Feb 28, 2025
@roblourens roblourens added the verified Verification succeeded label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2025
3 participants
@roblourens @rzhao271 @meganrogge