Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook leaks with actions and action runner #241324

Closed
bpasero opened this issue Feb 20, 2025 · 1 comment
Closed

Notebook leaks with actions and action runner #241324

bpasero opened this issue Feb 20, 2025 · 1 comment
Assignees
@DonJayamanne
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues

Comments

@bpasero
Copy link
Member

bpasero commented Feb 20, 2025

The things returned from here:

vscode/src/vs/workbench/contrib/notebook/browser/contrib/chatEdit/notebookChatActionsOverlay.ts

Line 107 in bfa04d6

actionViewItemProvider: (action, options) => {

Are not disposed it seems, this includes things extending ActionViewItem and NextPreviousChangeActionRunner
@bpasero bpasero added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Feb 20, 2025
@DonJayamanne
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonJayamanne DonJayamanne

Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @DonJayamanne