Skip to content

Test: Settings editor search improvements (Take 2) #241754

Closed
@rzhao271

Description

@rzhao271

Refs: #235852 (overarching epic), and specifically #221535 and #203838

Complexity: 4

Create Issue

Create Issue


Last iteration, we shipped a regression fix for the Settings editor where "editor formonpast" was not showing editor.formatOnPaste. I also implemented a new search algorithm behind a feature flag, but it was too buggy to ship with the flag enabled by default. This iteration, I continued working on the new settings search algorithm, which attempts to show fewer but more relevant results. However, the new search algorithm still does not implement synonym and typo detection.

Sanity testing section

  1. Open the Settings UI.
  2. Confirm that workbench.settings.useWeightedKeySearch is unchecked by default.
  3. Search for "editor formonpast".
  4. Confirm that editor.formatOnPaste shows up.
  5. Search for "stickyscrolle".
  6. Confirm that terminal.integrated.stickyScroll.enabled shows up.
  7. Enable workbench.settings.useWeightedKeySearch by checking the checkbox.
  8. Confirm that searching for "editor formonpast", "editor.formatonpaste", and "stickyscrolle" still yield the same expected setting(s) as before.
  9. Confirm that searching for "fomonpast" yields editor.formatOnPaste.
  10. Confirm that searching for "editor tab size" and "tab" both yield editor.tabSize as the first result.

Open testing section

Try out other queries with workbench.settings.useWeightedKeySearch enabled to search for your favourite settings!
Let me know if there are any queries that fail to yield an expected result, especially if the query yields the expected result with the setting disabled but not with the setting enabled.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions