Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal suggest: zsh's alias missing inline description and details #241822

Closed
chrmarti opened this issue Feb 25, 2025 · 5 comments · Fixed by #241967
Closed

Terminal suggest: zsh's alias missing inline description and details #241822

chrmarti opened this issue Feb 25, 2025 · 5 comments · Fixed by #241967
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal-suggest verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Collaborator

Testing #241749

zsh's alias is missing inline description and details:

Image Image
@chrmarti
Copy link
Collaborator Author

Similarly for others. It also doesn't know all listed as built-ins (e.g., bindkey). Maybe something isn't set up correctly? (This is on macOS.)

@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2025

Since the detail shows /usr/bin/alias that's showing the one on the PATH which is maybe wrong and we should show the builtin instead? I'm not actually sure what the alias executable does.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Feb 25, 2025
@Tyriar Tyriar added this to the February 2025 milestone Feb 25, 2025
@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2025

More cases like wait in #241823

@meganrogge meganrogge added the confirmed Issue has been confirmed by VS Code Team member label Feb 25, 2025
@meganrogge
Copy link
Contributor

meganrogge commented Feb 25, 2025

These all work in oss off of main

Image Image

@meganrogge
Copy link
Contributor

Looks like maybe /Users/meganrogge/Repos/vscode/extensions/terminal-suggest/src/shell/zshBuiltinsCache.json is not bundled with insider's

Image

if (!zshBuiltinsCommandDescriptionsCache) {
const cacheFilePath = path.join(__dirname, 'zshBuiltinsCache.json');
if (fs.existsSync(cacheFilePath)) {
try {
const cacheFileContent = fs.readFileSync(cacheFilePath, 'utf8');
const cacheObject = JSON.parse(cacheFileContent);
zshBuiltinsCommandDescriptionsCache = new Map(Object.entries(cacheObject));
} catch (e) {
console.error('Failed to load zsh builtins cache', e);
}
} else {
console.warn('zsh builtins cache not found');
}
}

meganrogge added a commit that referenced this issue Feb 25, 2025
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 25, 2025
@chrmarti chrmarti added the verified Verification succeeded label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal-suggest verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants