Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activeEditorState is not appended to window.title #241848

Closed
ntrogh opened this issue Feb 25, 2025 · 12 comments · Fixed by #241908
Closed

activeEditorState is not appended to window.title #241848

ntrogh opened this issue Feb 25, 2025 · 12 comments · Fixed by #241908
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@ntrogh
Copy link
Contributor

ntrogh commented Feb 25, 2025

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Latest insiders
  • OS Version: Windows latest

Testing TPI #241740

Steps to Reproduce:

  1. Toggle Screen Reader Accessibility Mode to enable it
  2. Window title doesn't show the editor info.
  3. The window.title setting doesn't have the activeEditorState included
  4. Manually add activeEditorState to window.title setting shows the editor info in the window title as expected.
window-title-activeEditorState.mp4
@meganrogge
Copy link
Contributor

@ntrogh did you also try enabling a screen reader - like NVDA?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Feb 25, 2025
@ntrogh
Copy link
Contributor Author

ntrogh commented Feb 25, 2025

@meganrogge not yet - just set the screen reader mode on

@meganrogge
Copy link
Contributor

Can you try with NVDA?

@meganrogge
Copy link
Contributor

Actually, I think I see what's happening. Can you just toggle screen reader mode - switch tabs, switch back to the tab with edits?

@meganrogge
Copy link
Contributor

Meaning do not modify the setting after enabling screen reader mode, just switch from the tab with edits then back to it. I believe the edits will be shown in the title.

@ntrogh
Copy link
Contributor Author

ntrogh commented Feb 25, 2025

I enabled screen reader mode, and then switched tabs, but nothing happens.

@meganrogge
Copy link
Contributor

A gif would help because I cannot reproduce that on mac - when I enable screen reader mode, switch tabs, come back to a tab with decorations, I see that in the window title.

@ntrogh
Copy link
Contributor Author

ntrogh commented Feb 25, 2025

  1. enable screen reader mode
  2. Ctrl+tab to switch between tabs
  3. Nothing happens to the title
window-title-activeEditorState2.mp4

@meganrogge
Copy link
Contributor

Thanks, and you haven't set "accessibility.windowTitleOptimized": false?

@meganrogge
Copy link
Contributor

and you see the screen reader optimized status bar item?

@ntrogh
Copy link
Contributor Author

ntrogh commented Feb 25, 2025

Setting is enabled, and yes I see the Status Bar item (also shows in the video)

Image

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues windows VS Code on Windows issues and removed info-needed Issue requires more information from poster labels Feb 25, 2025
@meganrogge meganrogge added this to the March 2025 milestone Feb 25, 2025
@meganrogge meganrogge removed the windows VS Code on Windows issues label Feb 25, 2025
@meganrogge meganrogge modified the milestones: March 2025, February 2025 Feb 25, 2025
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 25, 2025
@meganrogge
Copy link
Contributor

Note #242082 when verifying

@rzhao271 rzhao271 added the verified Verification succeeded label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants