UserDataSyncr contributions do not dispose Action

[benibenj]

Came across this code. Seems like it is not disposing the Action it is creating:

vscode/src/vs/workbench/contrib/userDataSync/browser/userDataSyncViews.ts

Line 383 in 949b5cf

new Action('reset', localize('reset', "Reset Synced Data"), undefined, true, () => this.userDataSyncWorkbenchService.resetSyncedData()),

UserDataSyncWorkbenchContribution (multiple cases in this class)

vscode/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts

Lines 307 to 310 in 949b5cf

	primary: [
	new Action('reset', localize('reset', "Clear Data in Cloud..."), undefined, true, () => this.userDataSyncWorkbenchService.resetSyncedData()),
	new Action('show synced data', localize('show synced data action', "Show Synced Data"), undefined, true, () => this.userDataSyncWorkbenchService.showSyncActivity())
	]

UserDataSyncReportIssueContribution (multiple cases in this class)

vscode/src/vs/workbench/contrib/userDataSync/browser/userDataSync.contribution.ts

Lines 44 to 47 in 949b5cf

	primary: [
	new Action('Show Sync Logs', localize('show sync logs', "Show Log"), undefined, true, () => this.commandService.executeCommand(SHOW_SYNC_LOG_COMMAND_ID)),
	new Action('Restart', isWeb ? localize('reload', "Reload") : localize('restart', "Restart"), undefined, true, () => this.hostService.restart())
	]

AbstractUserDataProfileElement

vscode/src/vs/workbench/contrib/userDataProfile/browser/userDataProfilesEditorModel.ts

Lines 312 to 318 in 949b5cf

	openAction: new Action('_openChild', localize('open', "Open to the Side"), ThemeIcon.asClassName(Codicon.goToFile), true, async () => {
	if (child.parent.type === ProfileResourceType.Extensions) {
	await this.commandService.executeCommand('extension.open', child.handle, undefined, true, undefined, true);
	} else if (child.resourceUri) {
	await this.commandService.executeCommand(API_OPEN_EDITOR_COMMAND_ID, child.resourceUri, [SIDE_GROUP], undefined);
	}
	}),

vscode/src/vs/workbench/contrib/userDataProfile/browser/userDataProfilesEditorModel.ts

Lines 312 to 318 in 949b5cf

	openAction: new Action('_openChild', localize('open', "Open to the Side"), ThemeIcon.asClassName(Codicon.goToFile), true, async () => {
	if (child.parent.type === ProfileResourceType.Extensions) {
	await this.commandService.executeCommand('extension.open', child.handle, undefined, true, undefined, true);
	} else if (child.resourceUri) {
	await this.commandService.executeCommand(API_OPEN_EDITOR_COMMAND_ID, child.resourceUri, [SIDE_GROUP], undefined);
	}
	}),

UserDataProfilesEditor (multiple cases in this class)

vscode/src/vs/workbench/contrib/userDataProfile/browser/userDataProfilesEditor.ts

Lines 222 to 230 in 949b5cf

	getActions: () => {
	const actions: IAction[] = [];
	if (this.templates.length) {
	actions.push(new SubmenuAction('from.template', localize('from template', "From Template"), this.getCreateFromTemplateActions()));
	actions.push(new Separator());
	}
	actions.push(new Action('importProfile', localize('importProfile', "Import Profile..."), undefined, true, () => this.importProfile()));
	return actions;
	}

UpdateContribution

vscode/src/vs/workbench/contrib/update/browser/update.ts

Lines 218 to 220 in 949b5cf

	new Action('', nls.localize('learn more', "Learn More"), undefined, undefined, () => {
	this.openerService.open('https://aka.ms/vscode-windows-setup');
	})