Bash builtins don't show Enhanced Documentation Support

[joshspicer]

Testing #241749

Following 3: Enhanced Documentation Support from TPI.

Version: 1.98.0-insider
Commit: ac0e8f0f32e3de145dc3aa11d8182f208a05397f
Date: 2025-02-25T05:06:39.916Z
Electron: 34.2.0
ElectronBuildId: 11044223
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Linux arm64 6.8.0-52-generic

[joshspicer]

I suppose showing test is a bad example as that's not even a built-in here. From my spot checking I don't think any of the built-ins listed from compgen -b are being shown

[meganrogge]

Are there any errors in the dev tools console? They're working for me

[Tyriar]

Related: #241822

[joshspicer]

Ok, I am seeing them now (even on fresh terminal). Nothing in devtools, but will keep an eye out for any hints.

[meganrogge]

Would be great if you can find a repro for when this doesn't work.

[Tyriar]

@meganrogge when it happens I always see the file path, so it seems like entries off PATH are taking priority over builtins, I think what we actually want to do here is always take the builtin instead.

[meganrogge]

The logic already works to have the builtin preferred over the executable. I think this suggests there's a case when the builtins are not able to be found/ there's an error in fetching them.

[meganrogge]

The order in which we add builtins/executables make it impossible for the executable to override the builtin. Thus why I think in this edge case, there's a problem fetching builtins.

vscode/extensions/terminal-suggest/src/terminalSuggestMain.ts

Lines 110 to 111 in a5636db

	// Order is important here, add shell globals first so they are prioritized over path commands
	const commands = [...shellGlobals, ...commandsInPath.completionResources];

vscode/extensions/terminal-suggest/src/terminalSuggestMain.ts

Lines 244 to 265 in a5636db

	const labels = new Set(items.map((i) => typeof i.label === 'string' ? i.label : i.label.label));
	for (const command of availableCommands) {
	const commandTextLabel = typeof command.label === 'string' ? command.label : command.label.label;
	if (!labels.has(commandTextLabel)) {
	items.push(createCompletionItem(
	terminalContext.cursorPosition,
	prefix,
	command,
	command.detail,
	command.documentation
	));
	labels.add(commandTextLabel);
	} else {
	const existingItem = items.find(i => (typeof i.label === 'string' ? i.label : i.label.label) === commandTextLabel);
	if (!existingItem) {
	continue;
	}
	const preferredItem = compareItems(existingItem, command);
	if (preferredItem) {
	items.splice(items.indexOf(existingItem), 1, preferredItem);
	}
	}

[meganrogge]

When you see this, I expect an error like Error getting info for... in the console.