Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting mixes filesystem and flags #241971

Open
TylerLeonhardt opened this issue Feb 25, 2025 · 4 comments
Open

Sorting mixes filesystem and flags #241971

TylerLeonhardt opened this issue Feb 25, 2025 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal-suggest
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Testing #241771

image

The sorting feels a little weird here... it's some filesystem completions, then flags, then more filesystem.

I feel like flags and such would be better on top.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal-suggest labels Feb 25, 2025
@meganrogge meganrogge added this to the Backlog milestone Feb 25, 2025
@meganrogge
Copy link
Contributor

Since sorting occurs as a user types, I don't think this is a big deal.

@Tyriar
Copy link
Member

Tyriar commented Feb 26, 2025

I think we boost . and ../ here specially here as we were optimizing for the file/folder path case, and ~ may be treated as the empty string since we ignore punctuation when sorting. Maybe you're right and flags should just always be above paths if they have the same score 🤔

@Tyriar Tyriar modified the milestones: Backlog, March 2025 Feb 26, 2025
@TylerLeonhardt
Copy link
Member Author

I feel like there's gonna be a scenario where I want them at the top... but idk it looks weird to me. This feels like a good setting option though... reminds me of "snippets at the bottom of completions"... we have some settings around influencing the sort

@Tyriar
Copy link
Member

Tyriar commented Feb 26, 2025

We probably will never be able to make people happy, there's an argument for all flags to be at the bottom unless - is the prefix too🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal-suggest
Projects
None yet
Development

No branches or pull requests

3 participants