Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview leaks #242034

Open
bpasero opened this issue Feb 26, 2025 · 1 comment
Open

Webview leaks #242034

bpasero opened this issue Feb 26, 2025 · 1 comment
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 26, 2025

[LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:276:18)
    at OverlayWebview._event [as onDidDispose] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:876:28)
    at Object.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:141:38)
(anonymous) @ lifecycle.ts:50
lifecycle.ts:50 [LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:276:18)
    at OverlayWebview._event [as onDidDispose] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:876:28)
    at MainThreadWebviewPanels.addWebviewInput (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadWebviewPanels.js:114:23)
    at Object.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:117:46)
    at RevivalPool.reviveFor (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:98:21)
    at WebviewEditorService.registerResolver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:212:27)
    at MainThreadCustomEditors.registerEditorProvider (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:109:55)
    at MainThreadCustomEditors.$registerCustomEditorProvider (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:99:14)
(anonymous) @ lifecycle.ts:50
lifecycle.ts:50 [LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:276:18)
    at OverlayWebview._event [as onDidDispose] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:876:28)
    at MainThreadWebviewPanels.addWebviewInput (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadWebviewPanels.js:114:23)
    at Object.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:117:46)
    at WebviewEditorService.tryRevive (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:229:31)
    at WebviewEditorService.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:236:38)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:48:99
    at createCancelablePromise (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/async.js:18:22)
(anonymous) @ lifecycle.ts:50
lifecycle.ts:50 [LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:276:18)
    at OverlayWebview._event [as onDidDispose] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:876:28)
    at Object.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:141:38)
    at async WebviewEditorService.tryRevive (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:229:17)
    at async WebviewEditorService.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:236:27)
(anonymous) @ lifecycle.ts:50
lifecycle.ts:50 [LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:276:18)
    at OverlayWebview._event [as onDidDispose] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:876:28)
    at MainThreadWebviewPanels.addWebviewInput (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadWebviewPanels.js:114:23)
    at Object.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:117:46)
    at WebviewEditorService.tryRevive (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:229:31)
    at WebviewEditorService.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:236:38)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:48:99
    at createCancelablePromise (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/async.js:18:22)
(anonymous) @ lifecycle.ts:50
lifecycle.ts:50 [LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/lifecycle.js:276:18)
    at OverlayWebview._event [as onDidDispose] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:876:28)
    at Object.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/api/browser/mainThreadCustomEditors.js:141:38)
    at async WebviewEditorService.tryRevive (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:229:17)
    at async WebviewEditorService.resolveWebview (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.js:236:27)
@bpasero bpasero added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Feb 26, 2025
@bpasero
Copy link
Member Author

bpasero commented Feb 26, 2025

I think partially from here:

input.webview.onDidDispose(() => {
this._proxy.$onDidDisposeWebviewPanel(handle).finally(() => {
this._webviewInputs.delete(handle);
});
});

webviewInput.webview.onDidDispose(() => {

const sub = modelRef.object.onDidChangeDirty(() => {

webviewInput.onMove(async (newResource: URI) => {

@mjbvz mjbvz added this to the March 2025 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Projects
None yet
Development

No branches or pull requests

2 participants