Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Night Owl Light appears much more blue with Tree Sitter highlighting #241887

Closed
rzhao271 opened this issue Feb 25, 2025 · 2 comments · Fixed by #242058
Closed

Night Owl Light appears much more blue with Tree Sitter highlighting #241887

rzhao271 opened this issue Feb 25, 2025 · 2 comments · Fixed by #242058
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-sitter
Milestone
March 2025

Comments

@rzhao271
Copy link
Contributor

Testing #241709

Both the light and dark themes of sdras.night-owl reveal differences in the following code block when Tree Sitter highlighting is on or off.

function test() {
	console.log('hello');
	return {
		foo: 'bar',
		baz: 'qux',
	}
}
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-sitter labels Feb 25, 2025
@alexr00 alexr00 added this to the February 2025 milestone Feb 25, 2025
@alexr00
Copy link
Member

alexr00 commented Feb 26, 2025

Really great sample of what extensions like to do, thanks!

@alexr00
Copy link
Member

alexr00 commented Feb 26, 2025

Some of these fixes require #241703, which is too risky to merge now.

@alexr00 alexr00 modified the milestones: February 2025, March 2025 Feb 26, 2025
alexr00 added a commit that referenced this issue Feb 26, 2025
@alexr00
Night Owl Light appears much more blue with Tree Sitter highlighting

Verified

This commit was signed with the committer’s verified signature.
meganrogge Megan Rogge
GPG key ID: B8E497F5C2C8EDE8
Verified
Learn about vigilant mode
Loading
Loading status checks…
ab0d5f9 
Fixes #241887
@alexr00 alexr00 mentioned this issue Feb 26, 2025
Merged
alexr00 added a commit that referenced this issue Mar 5, 2025
@alexr00
Night Owl Light appears much more blue with Tree Sitter highlighting

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9703fc6 
Fixes #241887
alexr00 added a commit that referenced this issue Mar 5, 2025
@alexr00
Night Owl Light appears much more blue with Tree Sitter highlighting
37235fe 
Fixes #241887
@alexr00 alexr00 closed this as completed in dfcb5f3 Mar 5, 2025
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 5, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-sitter
Projects
None yet
Milestone
March 2025
Development

Successfully merging a pull request may close this issue.

Night Owl Light appears much more blue with Tree Sitter highlighting microsoft/vscode
2 participants
@rzhao271 @alexr00