New issue

Jump to bottom

`ITextModel.onDidChangeContent` cannot be used with `observableFromEvent` #242059

Open

jrieken opened this issue Feb 26, 2025 · 0 comments

Assignees

Labels

debt

Milestone

Member

jrieken commented Feb 26, 2025 •

edited

Loading

See

vscode/src/vs/workbench/contrib/inlineChat/browser/inlineChatCurrentLine.ts

Lines 243 to 247 in 77dee8c

    
           // DEBT - I cannot use `model.onDidChangeContent` directly here 
        
           // https://github.com/microsoft/vscode/issues/242059 
        
           const emitter = store.add(new Emitter<void>()); 
        
           store.add(model.onDidChangeContent(() => emitter.fire())); 
        
           observableFromEvent(emitter.event, () => model.getVersionId()).read(r);

I had to do the weird workaround with the extra emitter because the onDidChangeContent event seems to be special

jrieken assigned hediet

hediet added the debt label

hediet added this to the March 2025 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment