Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybinding for disabling a11y verbosity on comments doesn't do it's job #242125

Closed
amunger opened this issue Feb 26, 2025 · 3 comments · Fixed by #242587
Closed

keybinding for disabling a11y verbosity on comments doesn't do it's job #242125

amunger opened this issue Feb 26, 2025 · 3 comments · Fixed by #242587
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Feb 26, 2025

while verifying #236769

  1. ensure "accessibility.verbosity.comments": true (default)
  2. focus a comment widget and press Alt+F1 to open a11y help
  3. notice it says pressing Alt+F6 will disable verbosity on this feature, try that keybinding
    🐛 verbosity is not disabled

looks like it tried to run the command, but the setting does not change:

2025-02-26 15:23:21.403 [info] [Window] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: F6, keyCode: 117, key: F6
2025-02-26 15:23:21.403 [info] [Window] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: F6, keyCode: 64 ('F6')
2025-02-26 15:23:21.403 [info] [Window] [KeybindingService]: | Resolving alt+F6
2025-02-26 15:23:21.404 [info] [Window] [KeybindingService]: \ From 1 keybinding entries, matched editor.action.accessibleViewDisableHint, when: accessibilityHelpIsShown && accessibleViewVerbosityEnabled || accessibleViewIsShown && accessibleViewVerbosityEnabled, source: built-in.
2025-02-26 15:23:21.404 [info] [Window] [KeybindingService]: + Invoking command editor.action.accessibleViewDisableHint.
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Feb 27, 2025
@alexr00 alexr00 added this to the March 2025 milestone Feb 27, 2025
@alexr00
Copy link
Member

alexr00 commented Mar 4, 2025

Where do you see that alt+F6 will disable verbosity? I'm not finding that in the help widget.

@alexr00 alexr00 removed this from the March 2025 milestone Mar 4, 2025
@amunger
Copy link
Contributor Author

amunger commented Mar 4, 2025

Image

@alexr00
Copy link
Member

alexr00 commented Mar 4, 2025

That's funny, I can't get it to show no matter what the setting is set to.

@alexr00 alexr00 added this to the March 2025 milestone Mar 4, 2025
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants