Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conpty and env reporting settings use an invalid default value #242227

Closed
Tyriar opened this issue Feb 27, 2025 · 0 comments · Fixed by #242228
Closed

Conpty and env reporting settings use an invalid default value #242227

Tyriar opened this issue Feb 27, 2025 · 0 comments · Fixed by #242228
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
February 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2025

vscode/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts

Lines 489 to 492 in 7427529

default: ((): boolean => {
const productService = Registry.as<IConfigurationRegistry>(Extensions.Configuration).getConfigurations()[0] as IProductConfiguration;
return productService?.quality !== 'stable';
})()

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Feb 27, 2025
@Tyriar Tyriar added this to the February 2025 milestone Feb 27, 2025
@Tyriar Tyriar self-assigned this Feb 27, 2025
Tyriar added a commit that referenced this issue Feb 27, 2025
@Tyriar
Fix default for conpty and env reporting settings
f61d38b 
Fixes #242227
@Tyriar Tyriar mentioned this issue Feb 27, 2025
Merged
@Tyriar Tyriar closed this as completed in cc54a91 Feb 27, 2025
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 27, 2025
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Fix default for conpty and env reporting settings microsoft/vscode
2 participants
@Tyriar @rzhao271