Hover with custom HTMLElement sets a fixed height, cutting off contents

[bpasero]

This makes debugging quite hard:

[benibenj]

Can you repro when using copilot pro? I'm not able to repro in that case:

[bpasero]

@benibenj yes, if its large enough:

[benibenj]

Seems like we are setting a max height for the hover. @Tyriar I find it a bit odd that we just hardcode a max height to 50% of the window. I think hovers should be allowed to take more than 50% of the height on small screens.

vscode/src/vs/editor/browser/services/hoverService/hoverWidget.ts

Lines 553 to 554 in bc9dcf3

	private adjustHoverMaxHeight(target: TargetRect): void {
	let maxHeight = this._targetWindow.innerHeight / 2;

@bpasero It looks like it is expected that you make your hover widget scrollable to support this case.

[bpasero]

I think we should increase this limit to avoid having to make it scrollable or define an option for it.

Moving to march, because this is very much visible in floating windows that are typically smaller in size: