Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leak in Settings Editor #242451

Closed
benibenj opened this issue Mar 3, 2025 · 1 comment · Fixed by #242525
Closed

Leak in Settings Editor #242451

benibenj opened this issue Mar 3, 2025 · 1 comment · Fixed by #242525
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders
Milestone
March 2025

Comments

@benibenj
Copy link
Contributor

benibenj commented Mar 3, 2025 

[LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/c:/Code/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/c:/Code/vscode/out/vs/base/common/lifecycle.js:198:24)
    at new Disposable (vscode-file://vscode-app/c:/Code/vscode/out/vs/base/common/lifecycle.js:393:9)
    at new AbstractEditorInput (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/common/editor.js:278:8)
    at new EditorInput (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/common/editor/editorInput.js:14:9)
    at new SettingsEditor2Input (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/services/preferences/common/preferencesEditorInput.js:27:9)
    at PreferencesService.createSettingsEditor2Input (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/services/preferences/browser/preferencesService.js:107:16)
    at PreferencesService.openSettings2 (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/services/preferences/browser/preferencesService.js:205:28)
    at PreferencesService.open (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/services/preferences/browser/preferencesService.js:202:18)
    at PreferencesService.openSettings (vscode-file://vscode-app/c:/Code/vscode/out/vs/workbench/services/preferences/browser/preferencesService.js:182:21)
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Mar 3, 2025
@rzhao271 rzhao271 added this to the March 2025 milestone Mar 3, 2025
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 3, 2025 •
edited
Loading

Repro steps:

  1. Open the UI Settings editor.
  2. Press the Open Settings (JSON) button on the top-right to open the JSON editor.
  3. Press the Open Settings (UI) button on the top-right to open the UI editor again.
  4. Repeat steps 2 and 3.
  5. 🐛 Leak

Verification steps:

  1. Open the UI Settings editor.
  2. Press the Open Settings (JSON) button on the top-right to open the JSON editor.
  3. Press the Open Settings (UI) button on the top-right to open the UI editor again.
  4. Repeat steps 2 and 3.
  5. Confirm there is no leak.
  6. Close the UI editor.
  7. Open or navigate to the JSON editor.
  8. Press the Open Settings (UI) button on the top-right to open the UI editor again.
  9. Ensure the Settings editor opens.
  10. Repeat steps 2 and 3.
  11. Confirm there is no leak.

@rzhao271 rzhao271 added the confirmed Issue has been confirmed by VS Code Team member label Mar 3, 2025
rzhao271 added a commit that referenced this issue Mar 4, 2025
@rzhao271
Fix another Settings editor leak
d957ba8 
Fixes #242451
@rzhao271 rzhao271 mentioned this issue Mar 4, 2025
Merged
rzhao271 added a commit that referenced this issue Mar 4, 2025
@rzhao271
Fix another Settings editor leak (#242525)
baa5479 
Fixes #242451
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
March 2025
Development

Successfully merging a pull request may close this issue.

Fix another Settings editor leak microsoft/vscode
2 participants
@rzhao271 @benibenj