Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasNavigatedSuggest should be cleared after widget hides #242582

Closed
meganrogge opened this issue Mar 4, 2025 · 0 comments · Fixed by #242584
Closed

hasNavigatedSuggest should be cleared after widget hides #242582

meganrogge opened this issue Mar 4, 2025 · 0 comments · Fixed by #242584
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Milestone
March 2025

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 4, 2025 •
edited
Loading

  1. enable terminal suggest and terminal.integrated.suggest.upArrowNavigatesHistory
  2. type and enter echo hello
  3. type e and up arrow
  4. ✅ history is navigated and the widget closes
  5. clear and type echo
  6. hit down arrow then up arrow twice
  7. ✅ suggest widget is navigated instead of history
  8. hit enter
  9. type and e and up arrow
  10. 🐛 widget is navigated instead of history
@meganrogge meganrogge self-assigned this Mar 4, 2025
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Mar 4, 2025
@meganrogge meganrogge added this to the March 2025 milestone Mar 4, 2025
@meganrogge meganrogge changed the title hasNavigatedSuggest should be cleared after command is executed hasNavigatedSuggest should be cleared after widget hides Mar 4, 2025
meganrogge added a commit that referenced this issue Mar 4, 2025
@meganrogge
fix #242582

Verified

This commit was signed with the committer’s verified signature.
meganrogge Megan Rogge
GPG key ID: B8E497F5C2C8EDE8
Verified
Learn about vigilant mode
Loading
Loading status checks…
6582d67
@meganrogge meganrogge mentioned this issue Mar 4, 2025
Merged
meganrogge added a commit that referenced this issue Mar 4, 2025
@meganrogge
on widget hide, reset context key (#242584)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
49fcfcc 
fix #242582
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Projects
None yet
Milestone
March 2025
Development

Successfully merging a pull request may close this issue.

on widget hide, reset context key microsoft/vscode
1 participant
@meganrogge