Support targeting multiple scopes in a theme with tree sitter

[alexr00]

No description provided.

[alexr00]

The identifiers are the scopes in a them rule. In this example, they are the scope property here:

{
			"name": "Function declarations",
			"scope": [
				"entity.name.function",
				"support.function",
				"support.constant.handlebars",
				"source.powershell variable.other.member",
				"entity.name.operator.custom-literal"
			],
			"settings": {
				"foreground": "#DCDCAA"
			}
		},

The scopes are the scopes that the token we're trying to find the theme for has. In this code snippet:

new URL('./../../renderer/dist/index.html', import.meta.url);

URL has the following scopes from tree sitter:

new.expr
variable
entity.name.function

By using the identifierIndex the score was using the position of the scope in the theme rule as to calculate the score, and I'm unclear on the intent behind this. Why would it's position in the theme rule influence the score?

This change instead uses the position of the scope in the token's scope list as part of the score, with scopes that are more specific getting greater weight.

[aeschli]

The change looks right. The higher up we find the identifier list in the scope, the more relevant rule is.
I think there's another issue: We should start looking from top to bottom
If the stack repeats, we would find the first occurrence, not the last. But the last one would have a higher score, which might beat other rules.

[aeschli]

I believe this regressed in https://github.com/microsoft/vscode/pull/229951/files

[alexr00]

I also thought https://github.com/microsoft/vscode/pull/229951/files could have regressed this, but I couldn't find a change in there that would have caused this.

[alexr00]

I think we are already going from top to bottom, since the for loop starts at the last index of the the scopes.
Edit, no we're not.