Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure window title is updated (considered custom) when in screen reader mode #241908

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

meganrogge
Copy link
Contributor

We need to make sure the window title is updated when in screen reader mode

if (that._windowTitle.isCustomTitleFormat()) {
label = that._windowTitle.getWindowTitle();
} else if (that._editorGroupService.partOptions.showTabs === 'none') {

fixes #241848
fixes #241882

@meganrogge meganrogge requested a review from bpasero February 25, 2025 17:50
@meganrogge meganrogge self-assigned this Feb 25, 2025
@meganrogge meganrogge added this to the February 2025 milestone Feb 25, 2025
@meganrogge meganrogge enabled auto-merge (squash) February 25, 2025 17:57
@meganrogge meganrogge merged commit 9bbae57 into main Feb 25, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/window-title-bug branch February 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants