Trigger change event in model when response model completes #242014
Conversation
| @@ -1585,6 +1591,7 @@ export class ChatModel extends Disposable implements IChatModel { | |||
| } | |||
|
|
|||
| request.response.complete(); | |||
| this._onDidChange.fire({ kind: 'completedRequest', request }); | |||
There was a problem hiding this comment.
We access chatModelrequestInProgress in chatEditingEditorContextKeys.ts.
However the onDidChange event doesn't trigger when the response is complete.
I found that this was the case in some cases for regular text editors as well.
More like a race condition.
In some cases the response complete variable is set before the session state is change.
Here onDidChange is never triggered, hence this is effectively the same as
const isRequestInProgress = chatModel?.requestInProgress === true
Usage
const isRequestInProgress = chatModel
? observableFromEvent(this, chatModel.onDidChange, () => chatModel.requestInProgress)
: constObservable(false);
There was a problem hiding this comment.
Thank you. I came to the same conclusion and would have done the same change.
This comment was marked as spam.
This comment was marked as spam.
| @@ -1585,6 +1591,7 @@ export class ChatModel extends Disposable implements IChatModel { | |||
| } | |||
|
|
|||
| request.response.complete(); | |||
| this._onDidChange.fire({ kind: 'completedRequest', request }); | |||
There was a problem hiding this comment.
Thank you. I came to the same conclusion and would have done the same change.
Fixes https://github.com/microsoft/vscode-copilot/issues/13559
Possibly fixes https://github.com/microsoft/vscode-copilot/issues/13485 as well.