Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't handle codeblockUri-parts as signal for edits #242038

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Feb 26, 2025

@jrieken jrieken self-assigned this Feb 26, 2025
@jrieken jrieken enabled auto-merge (squash) February 26, 2025 08:46
@jrieken jrieken requested a review from connor4312 February 26, 2025 08:46
@jrieken
Copy link
Member Author

jrieken commented Feb 26, 2025

@connor4312 this removes all handling of codeblockUri because text- and notebook-edits parts are self-contained and not need the leading uri. The codeblockUri is kinda deprecated (in my books) but wanna get your review in case I have missed anything

@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 26, 2025
@jrieken jrieken merged commit bb70a72 into main Feb 26, 2025
8 checks passed
@jrieken jrieken deleted the joh/surprised-raven branch February 26, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants