Support diffing notebook snapshots #242042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Feb 26, 2025
|
|
||
|
|
||
| registerNotebookContribution(NotebookChatEditorControllerContrib.ID, NotebookChatEditorControllerContrib); | ||
| registerSingleton(INotebookOriginalModelReferenceFactory, NotebookOriginalModelReferenceFactory, InstantiationType.Delayed); | ||
| registerSingleton(INotebookModelSynchronizerFactory, NotebookModelSynchronizerFactory, InstantiationType.Delayed); | ||
| registerSingleton(INotebookOriginalCellModelFactory, OriginalNotebookCellModelFactory, InstantiationType.Delayed); | ||
|
|
||
| registerWorkbenchContribution2(ChatEditingNotebookFileSystemProviderContrib.ID, ChatEditingNotebookFileSystemProviderContrib, WorkbenchPhase.BlockStartup); |
There was a problem hiding this comment.
Had to move this out of notebook folder into chatEditing.
Reason is the file system provider needs to access the chat services and its best to keep them closer
DonJayamanne
commented
Feb 26, 2025
| return serializeSnapshot(notebook.createSnapshot({ context: SnapshotContext.Backup, outputSizeLimit, transientOptions }), transientOptions); | ||
| } | ||
|
|
||
| function restoreSnapshot(notebook: NotebookTextModel, snapshot: string): void { |
There was a problem hiding this comment.
Moved out as this file as well as Notebook File System provider need to de-serialize snapshots.
DonJayamanne
commented
Feb 26, 2025
|
|
||
| if (entries?.before && ChatEditingModifiedNotebookEntry.canHandleSnapshot(entries.before)) { |
There was a problem hiding this comment.
Implementation for diffing in common code
rebornix
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-copilot/issues/13249
Fixes https://github.com/microsoft/vscode-copilot/issues/13540
Fixes https://github.com/microsoft/vscode-copilot/issues/13543