Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat: add #problems reference to core #242127

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

connor4312
Copy link
Member

  • Users can reference #problems in core now
  • It will ask the user to pick a file, or all files, when there's >1
    file with errors. (demo)
  • Tweaked the icon to match the error icon in the markers view

- Users can reference #problems in core now
- It will ask the user to pick a file, or all files, when there's >1
  file with errors. ([demo](https://memes.peet.io/img/25-02-8fbc8580-5f13-4714-b9d3-231edb53bdf7.mp4))
- Tweaked the icon to match the error icon in the markers view
@connor4312 connor4312 self-assigned this Feb 26, 2025
@connor4312 connor4312 enabled auto-merge (squash) February 26, 2025 23:46
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 26, 2025
filter: IDiagnosticVariableEntryFilterData;
}

export const isIChatRequestProblemsVariable = (obj: unknown): obj is IChatRequestProblemsVariable =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this used

@connor4312 connor4312 merged commit 39bf4cf into main Feb 27, 2025
8 checks passed
@connor4312 connor4312 deleted the connor4312/problems-dragging-feedback branch February 27, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants