Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal - use product to figure out quality #242226

Merged
merged 2 commits into from
Feb 28, 2025
Merged

terminal - use product to figure out quality #242226

merged 2 commits into from
Feb 28, 2025

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Feb 27, 2025

fyi @anthonykim1 , I am not sure what the code was doing you added before 🤔

@bpasero bpasero self-assigned this Feb 27, 2025
@bpasero bpasero requested a review from Tyriar February 27, 2025 19:39
@bpasero bpasero added this to the February 2025 milestone Feb 27, 2025
Tyriar
Tyriar previously approved these changes Feb 27, 2025
@anthonykim1
Copy link
Contributor

anthonykim1 commented Feb 28, 2025

I think I was trying to figure out how to get .quality but instead of using the product and just use product.quality, I tried to fetch the productService via

const productService = [Registry.as](http://registry.as/)<IConfigurationRegistry>(Extensions.Configuration).getConfigurations()[0] as IProductConfiguration;

This one looks much cleaner..

Thanks for this cleaning this up 🙏

@bpasero bpasero merged commit 6e6ef83 into main Feb 28, 2025
8 checks passed
@bpasero bpasero deleted the ben/logical-turkey branch February 28, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants