Fix to respect environment reporting setting in fish #242234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously approved these changes
Feb 27, 2025
| set myVar (echo $line | awk -F= '{print $1}') | ||
| set myVal (echo $line | awk -F= '{print $2}') | ||
| __vsc_esc EnvSingleEntry $myVar (__vsc_escape_value "$myVal") | ||
| if test $__vscode_shell_env_reporting -eq 1 |
There was a problem hiding this comment.
Can we put this on the outside so the event listener isn't set up if this isn't set?
There was a problem hiding this comment.
Yeah, I hope that makes it a bit faster 6bf76d9
Tyriar
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further resolves: #241991
This will not send env info if user setting is off on fish, and respect the env reporting setting on fish just like we do for pwsh,bash,zsh.