disable, restart extension host, uninstall and remove problematic extension #242249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
approved these changes
Feb 28, 2025
joaomoreno
reviewed
Feb 28, 2025
Comment on lines
+2982
to
+2989
| await this.extensionManagementService.uninstallExtensions([{ | ||
| extension: e.local, | ||
| options: { | ||
| remove: true, | ||
| donotCheckDependents: true, | ||
| context: { [EXTENSION_UNINSTALL_MALICIOUS_CONTEXT]: true } | ||
| } | ||
| }]); |
There was a problem hiding this comment.
If this takes an array of extensions to uninstall, why aren't we using a single call to this method, instead of N calls?
There was a problem hiding this comment.
Yes, you are right. I overlooked it.
Comment on lines
+2990
to
+2998
| this.notificationService.prompt( | ||
| Severity.Warning, | ||
| nls.localize('malicious warning', "The extension '{0}' was found to be problematic and has been removed.", e.identifier.id), | ||
| [], | ||
| { | ||
| sticky: true, | ||
| priority: NotificationPriority.URGENT | ||
| } | ||
| ); |
There was a problem hiding this comment.
Does this means that if 2 malicious extensions are removed, the user will get 2 popups?
There was a problem hiding this comment.
Yes, it was same as before.
| @@ -1011,9 +1013,11 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension | |||
|
|
|||
| this.updatesCheckDelayer = new ThrottledDelayer<void>(ExtensionsWorkbenchService.UpdatesCheckInterval); | |||
| this.autoUpdateDelayer = new ThrottledDelayer<void>(1000); | |||
| this.maliciousExtensionsCheckDelayer = new ThrottledDelayer<void>(1000 * 60 * 5 /* every five minutes */); | |||
There was a problem hiding this comment.
You really just need a Delayer here. Or a regular timeout, like before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable, restart extension host, uninstall and remove problematic extension