Fix icon sizing for themes with custom font-sizes #242257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
joyceerhl
reviewed
Feb 27, 2025
|
Good call. I don't think we can get the icons always looking consistent but here's what it should look like after a few more tweaks: 
This theme defines its icons to be on the larger size. They even look a little oversized to me in the explorer. I've fixed this to be more reasonable and not overflow the widget but if I force these icons to be a better looking size, a bunch of our other icon themes break |
joyceerhl
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.