-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add second config setting for the reusable prompts
feature
#242268
Conversation
…blic feature name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments but approving to make sure it gets in
default: true, | ||
restricted: true, | ||
disallowConfigurationDefault: true, | ||
tags: ['experimental', 'prompts', 'reusable prompts', 'prompt snippets', 'instructions'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a small set of tags, these show up with @tags
in the settings editor. Not sure whether you mean for all of these to be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I expected (and I've checked that) it uses only the experimental
tag from the list in the UI. I wanted to add the other tags as a documentation of all other names we were calling the feature, and I hoped that maybe it will aid with search through the settings (it seems to not 😞).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see
The PR:
reusable prompts
feature dedicated solely to the feature enablementuse prompt
andcreate prompt
(and their keybindings) conditionally, based on the new config setting state (enabled/disabled)