Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add second config setting for the reusable prompts feature #242268

Merged
merged 8 commits into from
Feb 28, 2025

Conversation

legomushroom
Copy link
Member

The PR:

  • adds the second config setting for the reusable prompts feature dedicated solely to the feature enablement
  • registers the use prompt and create prompt (and their keybindings) conditionally, based on the new config setting state (enabled/disabled)
  • fixes issue prompt attachment ID issue

@legomushroom legomushroom added this to the February 2025 milestone Feb 28, 2025
@legomushroom legomushroom self-assigned this Feb 28, 2025
roblourens
roblourens previously approved these changes Feb 28, 2025
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but approving to make sure it gets in

default: true,
restricted: true,
disallowConfigurationDefault: true,
tags: ['experimental', 'prompts', 'reusable prompts', 'prompt snippets', 'instructions'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a small set of tags, these show up with @tags in the settings editor. Not sure whether you mean for all of these to be added

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I expected (and I've checked that) it uses only the experimental tag from the list in the UI. I wanted to add the other tags as a documentation of all other names we were calling the feature, and I hoped that maybe it will aid with search through the settings (it seems to not 😞).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see

@legomushroom legomushroom merged commit 715bdfa into main Feb 28, 2025
8 checks passed
@legomushroom legomushroom deleted the legomushroom/add-second-config-setting branch February 28, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants