# Allow inlineEdits to signal visibility #242287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Current inlineEdits inherited the inlineCompletion pathways, but are not fully integrated. So while we can listen to acceptance of inlineEdit, we can't listen to inlineEdit being visible.
Proposal
Add the inlineEdit state in to the show handler & use the inlineEdit completion content as well as the lastItem. This would allow downstream consumers to listen to changes and react to either inline completion or the inline edit being visible & apply logging heuristicts (such as visibility after certain period of time).
The extensions should be easily able to draw the line between the inlineEdits and the inlineCompletions by filtering on the isInlineEdit property.