Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Allow inlineEdits to signal visibility #242287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marrej
Copy link
Contributor

@marrej marrej commented Feb 28, 2025

Problem Statement

Current inlineEdits inherited the inlineCompletion pathways, but are not fully integrated. So while we can listen to acceptance of inlineEdit, we can't listen to inlineEdit being visible.

Proposal

Add the inlineEdit state in to the show handler & use the inlineEdit completion content as well as the lastItem. This would allow downstream consumers to listen to changes and react to either inline completion or the inline edit being visible & apply logging heuristicts (such as visibility after certain period of time).

The extensions should be easily able to draw the line between the inlineEdits and the inlineCompletions by filtering on the isInlineEdit property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants