# Full acceptance signal for the inlineCompletions

[marrej]

Problem statement

The current acceptance always signals only partial edits. Once the full edit is hit the full acceptance command is triggered (even though this was signalled from the partial acceptance), this reduces understanding in to when the partial acceptance signals are used (e.g. users accepting completions via line acceptances at all times).

The patial acceptance handler also can carry more data that can be core calculated, improving the data flow without need for extension overwork.

lastly it allows to paint the full picture with the handlers without the dichotomy of "handlers+commands", and always expects the show->accept->show/reject as next signal. (Note that 242284 tries to add the reject)

Proposal

Extend the current Accept handler to allow the partial accepts to signal through it that they have been invoked.
Add observable value in the didShow to allow it to be always outside ot the Acceptance, allowing for correct interpretation of show->accept->reject/show

note that with #241356 a much better picture could be captured of the whole code completion lifecycle.