More reuse via abstract modified file entry #242311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
commented
Feb 28, 2025
| @@ -391,6 +392,15 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie | |||
| this.cellEntryMap.forEach(entry => !entry.disposed && entry.clearCurrentEditLineDecoration()); | |||
| } | |||
|
|
|||
| protected override _createUndoRedoElement(response: IChatResponseModel): IUndoRedoElement { | |||
| throw new Error('NOT IMPLEMENTED'); | |||
There was a problem hiding this comment.
@DonJayamanne please implement these two methods
There was a problem hiding this comment.
I've added support for _areOriginalAndModifiedIdentical
And made the method _createUndoRedoElement support returning undefined for now, that way we can add support for this later @amunger will be working on that.
DonJayamanne
previously approved these changes
Mar 1, 2025
bpasero
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re https://github.com/microsoft/vscode-copilot/issues/13692 and https://github.com/microsoft/vscode-copilot/issues/13693