Ensure cell Id is the only part of internal metadata used in diffing #242382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Mar 1, 2025
| @@ -56,7 +56,8 @@ class MirrorCell { | |||
| hashValue = doHash(this.language, hashValue); | |||
| hashValue = doHash(this.getValue(), hashValue); | |||
| hashValue = doHash(this.metadata, hashValue); | |||
| hashValue = doHash({ ...this.internalMetadata, 'cellId': '' }, hashValue); | |||
| // For purpose of diffing only cellId matters, rest do not | |||
| hashValue = doHash(this.internalMetadata?.cellId || '', hashValue); | |||
There was a problem hiding this comment.
@amunger If internal metadata, such as cell state or anything else thats internal changes, then this cell is marked as changed.
For the purpose of diffing none of the values matter, in face prior to your PR, internal metadata wasn't synced with worker, hence this is a valid change.
runStartTimeAdjustment?: number;
runEndTime?: number;
renderDuration?: { [key: string]: number };
bpasero
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.