Sync hashing of notebook outputs, hence sync nb diffing #242386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Mar 1, 2025
| op.outputs.map(o => crypto.subtle.digest('sha-1', o.data.buffer)) | ||
| )); | ||
| const digests = this.outputs.flatMap(op => | ||
| op.outputs.map(o => hash(Array.from(o.data.buffer))) |
There was a problem hiding this comment.
Using the same technique used in renderer process to compute of hashes of outputs.
Also makes it simpler
A separate PR would be to change computeDiff to make it sync, however thats a bigger change and leaving that for later.
@rebornix /cc
rebornix
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.