Add PowerShell logic to prevent hanging installer Fix #239521 #242427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PowerShell hanging on update is caused by the `Remove-AppxPackage` failure. These changes ensure that 1. PowerShell does not attempt to load the user's profile (which might itself cause the install to hang) 2. If the Remove-AppxPackage fails, the PowerShell instance gracefully exits
Add `-Confirm:$false -ErrorAction SilentlyContinue` to the `UninstallRun`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a pull request description based on the provided changes:
Pull Request Description
Summary
This pull request addresses the issue #239521, where the PowerShell hanging on update is caused by the
Remove-AppxPackagefailure. The changes ensure that:Remove-AppxPackagefails, the PowerShell instance gracefully exits.Details
Changes in
code.iss:-NonInteractive -NoProfile -NoLogo -Confirm:$false -ErrorAction SilentlyContinue.UninstallRunandRemoveAppxPackageprocedure to include these parameters.These changes need to be tested to determine if the single-quoting on the commands is sufficient and well-formed.