dispose 3 leaked disposables #242519
Merged
dispose 3 leaked disposables #242519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2025 14:39
rzhao271
approved these changes
Mar 3, 2025
connor4312
reviewed
Mar 5, 2025
| @@ -366,7 +367,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende | |||
| outputShowMoreContainer, | |||
| editor, | |||
| templateDisposables, | |||
| elementDisposables: new DisposableStore(), | |||
| elementDisposables: this._register(new DisposableStore()), | |||
There was a problem hiding this comment.
elementDisposables should be registered into the templateDisposables -- this has a similar leak as renderTemplate can be called an arbitrary number of times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce some console errors