Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require 'prompt files' synchronization to be explicitly enabled by users #242567

Merged
merged 1 commit into from
Mar 4, 2025
Merged

require 'prompt files' synchronization to be explicitly enabled by users #242567

merged 1 commit into from
Mar 4, 2025

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Mar 4, 2025 •
edited
Loading

Fixes #242360

Changes by @legomushroom And @sandy081

What it does:

  • disables the syncing of prompts by default (see isResourceEnabled) unless the user has set it
  • when the user first time turns on setting sync, prompts are selected by default (userDataSync.ts, line 532)
  • when the user has settings sync running already and opens the config dialog, it will reflect the current behavior (prompts disabled) (userDataSync.ts, line 611)

@aeschli aeschli self-assigned this Mar 4, 2025
@aeschli aeschli enabled auto-merge (squash) March 4, 2025 15:23
@aeschli aeschli added this to the February 2025 milestone Mar 4, 2025
@aeschli aeschli merged commit 0f18d5d into release/1.98 Mar 4, 2025
8 checks passed
@aeschli aeschli deleted the aeschli/assistant-ptarmigan-163 branch March 4, 2025 15:55
@legomushroom legomushroom mentioned this pull request Mar 4, 2025
Closed
@aeschli aeschli assigned legomushroom and sandy081 and unassigned aeschli Mar 4, 2025
aeschli
aeschli commented Mar 4, 2025
View reviewed changes
Copy link
Contributor Author

@aeschli aeschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@legomushroom legomushroom restored the aeschli/assistant-ptarmigan-163 branch March 4, 2025 17:47
@legomushroom legomushroom mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legomushroom legomushroom

Assignees

@legomushroom legomushroom

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@aeschli @legomushroom @sandy081