Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render chat implicit context widget even if there are no real attachments #242574

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix: render chat implicit context widget even if there are no real attachments #242574

merged 1 commit into from
Mar 4, 2025

Conversation

joyceerhl
Copy link
Collaborator

Fix #242572

@joyceerhl joyceerhl self-assigned this Mar 4, 2025
@joyceerhl joyceerhl enabled auto-merge (squash) March 4, 2025 16:09
@joyceerhl joyceerhl merged commit 8d53e80 into release/1.98 Mar 4, 2025
8 checks passed
@joyceerhl joyceerhl deleted the joyce/smiling-stingray branch March 4, 2025 16:47
connor4312 added a commit that referenced this pull request Mar 4, 2025
@connor4312
Revert "fix: render chat implicit context widget even if there are no…
12370a2 
… real attachments (#242574)"

This reverts commit 8d53e80.
connor4312 added a commit that referenced this pull request Mar 4, 2025
@connor4312
Revert "fix: avoid extra gaps between attachments in chat input part (#…
fd0af44 
…242497)" (#242577)

* Revert "fix: render chat implicit context widget even if there are no real attachments (#242574)"

This reverts commit 8d53e80.

* Revert "fix: avoid extra gaps between attachments in chat input part (#242497)"

This reverts commit 21d13f4.
@aeschli aeschli mentioned this pull request Mar 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor4312 connor4312

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joyceerhl @connor4312