ensure alias value is used for spec when generating completions #242585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously requested changes
Mar 4, 2025
There was a problem hiding this comment.
I don't think we can do this actually since aliases can be more than just running executables. For example:
alias s="for i in {1..5}; do echo "hello"; sleep 1; done"
For the case in the issue, the important thing we must ensure is that definitionCommand is used to source the relevant fig spec, so we don't show the python spec completions for pythonfake.
meganrogge
changed the title
Tyriar
previously approved these changes
Mar 4, 2025
anthonykim1
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #242522