Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybinding for disabling a11y verbosity on comments doesn't do it's job #242587

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Mar 4, 2025

Fixes #242125

@alexr00 alexr00 self-assigned this Mar 4, 2025
@alexr00 alexr00 requested a review from meganrogge March 4, 2025 17:54
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 4, 2025
Copy link
Member Author

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meganrogge, I debated changing the comments accessibility provider to extend AccessibleContentProvider, but this isn't the only provider that implements the IAccessibleViewContentProvider interface, and even if I change all the providers that do this, we could still end up with "bad" providers doing this again in the future.

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexr00 alexr00 merged commit 8be43d2 into main Mar 5, 2025
8 checks passed
@alexr00 alexr00 deleted the alexr00/issue242125 branch March 5, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keybinding for disabling a11y verbosity on comments doesn't do it's job
2 participants