Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Set field name as json path if not specified #40419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Mar 6, 2025

issue: #35528

@sre-ci-robot sre-ci-robot requested review from czs007 and zwd1208 March 6, 2025 09:47
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 6, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 6, 2025
Copy link
Contributor

mergify bot commented Mar 6, 2025

@sunby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. dco-passed DCO check passed. and removed dco-passed DCO check passed. needs-dco DCO is missing in this pull request. labels Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (63a7c45) to head (c978295).
Report is 43 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40419       +/-   ##
===========================================
+ Coverage   69.97%   82.14%   +12.17%     
===========================================
  Files         309     1165      +856     
  Lines       27718   179885   +152167     
===========================================
+ Hits        19396   147771   +128375     
- Misses       8322    26041    +17719     
- Partials        0     6073     +6073     
Components Coverage Δ
Client 79.74% <ø> (∅)
Core ∅ <ø> (∅)
Go 82.27% <83.23%> (∅)
Files with missing lines Coverage Δ
internal/proxy/task_index.go 73.55% <100.00%> (ø)
internal/util/indexparamcheck/inverted_checker.go 82.35% <ø> (ø)

... and 1472 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented Mar 11, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Copy link
Contributor

mergify bot commented Mar 11, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 11, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Mar 11, 2025
issue: #35528 
pr: #40407 
this pr includes some json index related pr:
1. #40407
2. #40538 
3. #40419

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
bigsheeper pushed a commit to bigsheeper/milvus that referenced this pull request Mar 12, 2025
* enhance: [2.5] Fix Array.h clang format issue (milvus-io#40536)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* fix: cherry pick json index related prs (milvus-io#40568)

issue: milvus-io#35528 
pr: milvus-io#40407 
this pr includes some json index related pr:
1. milvus-io#40407
2. milvus-io#40538 
3. milvus-io#40419

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>

* Refine task meta with key lock

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: congqixia <congqi.xia@zilliz.com>
Co-authored-by: Bingyi Sun <sunbingyi1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants