Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance[2.5]: add more config for interimIndex to support more refine mode #40429

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

cqy123456
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Mar 6, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Mar 6, 2025
Copy link
Contributor

mergify bot commented Mar 6, 2025

@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Mar 6, 2025

@cqy123456

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@dosubot dosubot bot added the kind/enhancement Issues or changes related to enhancement label Mar 6, 2025
Copy link
Contributor

mergify bot commented Mar 6, 2025

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.5@4a3a1b7). Learn more about missing BASE report.

Current head dad0464 differs from pull request most recent head 50cd02e

Please upload reports for the commit 50cd02e to get more accurate results.

Files with missing lines Patch % Lines
internal/core/src/segcore/segcore_init_c.cpp 0.00% 15 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 2 Missing ⚠️
internal/core/src/segcore/FieldIndexing.cpp 80.00% 1 Missing ⚠️
internal/core/src/segcore/SegcoreConfig.h 93.33% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5   #40429   +/-   ##
======================================
  Coverage       ?   70.16%           
======================================
  Files          ?      304           
  Lines          ?    28389           
  Branches       ?        0           
======================================
  Hits           ?    19920           
  Misses         ?     8469           
  Partials       ?        0           
Components Coverage Δ
Client ∅ <ø> (?)
Core 70.16% <66.66%> (?)
Go ∅ <ø> (?)
Files with missing lines Coverage Δ
internal/core/src/segcore/FieldIndexing.h 69.56% <ø> (ø)
internal/core/src/segcore/IndexConfigGenerator.cpp 86.07% <100.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 80.92% <100.00%> (ø)
internal/core/src/segcore/FieldIndexing.cpp 69.01% <80.00%> (ø)
internal/core/src/segcore/SegcoreConfig.h 97.05% <93.33%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.40% <0.00%> (ø)
internal/core/src/segcore/segcore_init_c.cpp 22.89% <0.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@cqy123456 cqy123456 force-pushed the interimindex-refine branch from dad0464 to 50cd02e Compare March 13, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants