Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Increase search/query retry times on proxy before timeout #40438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #39379

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 7, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 7, 2025
@dosubot dosubot bot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 7, 2025
@weiliu1031 weiliu1031 force-pushed the increase_retry_times branch from eccb085 to cf55e06 Compare March 7, 2025 03:47
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (2eaf997) to head (bb9e3f7).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40438       +/-   ##
===========================================
+ Coverage   70.03%   80.55%   +10.51%     
===========================================
  Files         309     1474     +1165     
  Lines       27725   207476   +179751     
===========================================
+ Hits        19417   167127   +147710     
- Misses       8308    34286    +25978     
- Partials        0     6063     +6063     
Components Coverage Δ
Client 79.74% <ø> (∅)
Core 70.01% <ø> (-0.02%) ⬇️
Go 82.30% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <100.00%> (ø)

... and 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031 weiliu1031 force-pushed the increase_retry_times branch from cf55e06 to d1b2adc Compare March 7, 2025 09:29
@weiliu1031
Copy link
Contributor Author

rerun ut

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the increase_retry_times branch from d1b2adc to bb9e3f7 Compare March 10, 2025 10:06
Copy link
Contributor

mergify bot commented Mar 10, 2025

@weiliu1031 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants