Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: move object storage client creation to pkg package #40440

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

jaime0815
Copy link
Contributor

issue: #40439

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file labels Mar 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 7, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Mar 7, 2025
Copy link
Contributor

mergify bot commented Mar 7, 2025

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 7, 2025

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 77.08978% with 74 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (a56b240) to head (aa81fe1).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
pkg/objectstorage/util.go 63.18% 64 Missing and 10 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40440       +/-   ##
===========================================
+ Coverage   70.04%   80.55%   +10.50%     
===========================================
  Files         309     1475     +1166     
  Lines       27725   207617   +179892     
===========================================
+ Hits        19421   167252   +147831     
- Misses       8304    34303    +25999     
- Partials        0     6062     +6062     
Components Coverage Δ
Client 79.74% <ø> (∅)
Core 70.00% <ø> (-0.05%) ⬇️
Go 82.31% <77.08%> (∅)
Files with missing lines Coverage Δ
internal/indexnode/chunk_mgr_factory.go 92.00% <100.00%> (ø)
internal/storage/azure_object_storage.go 86.60% <100.00%> (ø)
internal/storage/factory.go 94.87% <100.00%> (ø)
internal/storage/gcp_native_object_storage.go 68.00% <100.00%> (ø)
internal/storage/local_chunk_manager.go 67.28% <100.00%> (ø)
internal/storage/minio_object_storage.go 78.72% <100.00%> (ø)
internal/storage/remote_chunk_manager.go 73.86% <100.00%> (ø)
internal/storage/utils.go 88.06% <100.00%> (ø)
internal/util/dependency/factory.go 69.66% <100.00%> (ø)
pkg/objectstorage/aliyun/aliyun.go 100.00% <ø> (ø)
... and 4 more

... and 1155 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented Mar 7, 2025

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 7, 2025

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the move-os-client branch 4 times, most recently from 1f6c39d to dfeca8f Compare March 11, 2025 03:33
Copy link
Contributor

mergify bot commented Mar 11, 2025

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: jaime <yun.zhang@zilliz.com>
Copy link
Contributor

mergify bot commented Mar 11, 2025

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 12, 2025
@dosubot dosubot bot added the lgtm label Mar 12, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c8a9637 into milvus-io:master Mar 12, 2025
18 of 20 checks passed
@jaime0815 jaime0815 deleted the move-os-client branch March 12, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. go Pull requests that update Go code kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants