Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5][GoSDK] move metaheader to client in case of race #40444

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #40443
See failure run in #40352

This PR:

  • move metaheader map to client struct from config
  • set default value for field schema

See failure run in milvus-io#40352

This PR:
- move metaheader map to client struct from config
- set default value for field schema

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 7, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dosubot dosubot bot added component/gosdk issues & PRs related to GoSDK package PR | need cherry-pick need cherry pick to other branches labels Mar 7, 2025
Copy link
Contributor

mergify bot commented Mar 7, 2025

@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Mar 7, 2025
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (54a2509) to head (41ea3cb).
Report is 7 commits behind head on 2.5.

Files with missing lines Patch % Lines
client/milvusclient/client.go 33.33% 6 Missing and 2 partials ⚠️
client/milvusclient/interceptors.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40444      +/-   ##
==========================================
+ Coverage   80.92%   80.94%   +0.02%     
==========================================
  Files        1419     1419              
  Lines      200489   200491       +2     
==========================================
+ Hits       162242   162293      +51     
+ Misses      32579    32537      -42     
+ Partials     5668     5661       -7     
Components Coverage Δ
Client 79.77% <43.75%> (+0.04%) ⬆️
Core 70.17% <ø> (ø)
Go 82.85% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
client/entity/field.go 59.09% <100.00%> (+0.47%) ⬆️
client/milvusclient/client_config.go 39.58% <ø> (+4.58%) ⬆️
client/milvusclient/interceptors.go 59.30% <0.00%> (ø)
client/milvusclient/client.go 56.73% <33.33%> (-2.50%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@congqixia congqixia removed the needs-dco DCO is missing in this pull request. label Mar 7, 2025
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Mar 7, 2025
@zhikunyao zhikunyao removed the needs-dco DCO is missing in this pull request. label Mar 7, 2025
@mergify mergify bot added needs-dco DCO is missing in this pull request. ci-passed labels Mar 7, 2025
@sre-ci-robot sre-ci-robot merged commit 9cf2cb6 into milvus-io:2.5 Mar 10, 2025
27 of 30 checks passed
@congqixia congqixia deleted the cp25/gosdk/40443 branch March 11, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed component/gosdk issues & PRs related to GoSDK package kind/bug Issues or changes related a bug lgtm needs-dco DCO is missing in this pull request. PR | need cherry-pick need cherry pick to other branches size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants