-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.5][GoSDK] move metaheader to client in case of race #40444
Conversation
See failure run in milvus-io#40352 This PR: - move metaheader map to client struct from config - set default value for field schema Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #40444 +/- ##
==========================================
+ Coverage 80.92% 80.94% +0.02%
==========================================
Files 1419 1419
Lines 200489 200491 +2
==========================================
+ Hits 162242 162293 +51
+ Misses 32579 32537 -42
+ Partials 5668 5661 -7
🚀 New features to boost your workflow:
|
Cherry-pick from master
pr: #40443
See failure run in #40352
This PR: