Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Only check element type with not null array #40446

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

xiaocai2333
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 7, 2025
czs007 pushed a commit that referenced this pull request Mar 7, 2025
master pr: #40446

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (2bd2cca) to head (8d5fd64).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40446       +/-   ##
===========================================
+ Coverage   70.01%   80.53%   +10.51%     
===========================================
  Files         309     1474     +1165     
  Lines       27710   207476   +179766     
===========================================
+ Hits        19402   167089   +147687     
- Misses       8308    34307    +25999     
- Partials        0     6080     +6080     
Components Coverage Δ
Client 79.74% <ø> (∅)
Core 70.01% <100.00%> (ø)
Go 82.28% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.cpp 87.02% <100.00%> (ø)

... and 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 7, 2025
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Mar 11, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e5f5007 into milvus-io:master Mar 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants