Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip executing stats for zero segment #40448

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

xiaocai2333
Copy link
Contributor

issue: #40241

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (a56b240) to head (875b189).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40448       +/-   ##
===========================================
+ Coverage   70.04%   80.52%   +10.47%     
===========================================
  Files         309     1474     +1165     
  Lines       27725   207407   +179682     
===========================================
+ Hits        19421   167010   +147589     
- Misses       8304    34332    +26028     
- Partials        0     6065     +6065     
Components Coverage Δ
Client 79.69% <ø> (∅)
Core 70.03% <ø> (-0.02%) ⬇️
Go 82.27% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/task_stats.go 91.43% <100.00%> (ø)

... and 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 7, 2025
sre-ci-robot pushed a commit that referenced this pull request Mar 7, 2025
issue : #40241 

master pr: #40448

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Mar 9, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d6a650b into milvus-io:master Mar 9, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants