Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store wrong offset when build tantivy in nullable field #40452

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Mar 7, 2025

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 7, 2025
Copy link
Contributor

mergify bot commented Mar 7, 2025

@smellthemoon Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.51%. Comparing base (a56b240) to head (2a0fcf8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/index/InvertedIndexTantivy.cpp 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40452       +/-   ##
===========================================
+ Coverage   70.04%   80.51%   +10.46%     
===========================================
  Files         309     1474     +1165     
  Lines       27725   207394   +179669     
===========================================
+ Hits        19421   166976   +147555     
- Misses       8304    34346    +26042     
- Partials        0     6072     +6072     
Components Coverage Δ
Client 79.69% <ø> (∅)
Core 70.03% <33.33%> (-0.02%) ⬇️
Go 82.25% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.cpp 87.02% <33.33%> (ø)

... and 1166 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented Mar 7, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Mar 7, 2025
…0453)

pr: #40452 
issue: #40454

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 7, 2025
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smellthemoon, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit faae8ee into milvus-io:master Mar 9, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants